move chart to subdirectory #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksym-iv-elf
requested changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM, but we may change the name in the templates a bit.
By default the only place where {{ include "helm_foobar.name" . }} is used is helpers, in
{{/*
Selector labels
*/}}
{{- define "helm_foobar.selectorLabels" -}}
app.kubernetes.io/name: {{ include "helm_foobar.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end }}
And everywhere else {{ include "helm_foobar.fullname" . }} is used.
And we may want to add to the helpers and use {{ include "netobserve.serviceAccountName" . }} (from standard)
{{/*
Create a default fully qualified app name.
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
If release name contains chart name it will be used as a full name.
*/}}
{{- define "netobserve.fullname" -}}
{{- if .Values.fullnameOverride }}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- $name := default .Chart.Name .Values.nameOverride }}
{{- if contains $name .Release.Name }}
{{- .Release.Name | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }}
{{- end }}
{{- end }}
{{- end }}
| @@ -7,4 +7,4 @@ | |||
|
|
|||
| # Misc | |||
| tmp.* | |||
| charts/** | |||
| charts/netobserv/charts/** | |||
There was a problem hiding this comment.
Suggested change
| charts/netobserv/charts/** | |
| charts/netobserv/** |
There was a problem hiding this comment.
that would ignore all of the templates 😱
There was a problem hiding this comment.
But charts/netobserv/charts/** does not seem to exist
There was a problem hiding this comment.
this is where the helm dep update and helm dep build write to
Co-authored-by: Mack (Maksym Iv) <[email protected]>
maksym-iv-elf
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To follow a similar format to helm's create option, this moves the chart into a subdirectory. It also simplifies the image config.